playframework / playframework/playframework.com
modules dependencies always return a dependencies.yml content even if the module doesn't exist
Open
Nobody has claimed this yet.
status:backlog
- Dominant language
- Scala
- Stars
- 44
- Forks
- 62
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 3
Description
GET /modules/repo/:name/:version/dependencies.yml controllers.Modules.dependencies(name, version)
and in modules.scala
In modulesLookup.findDependencies(name, version) match {
case Some(yml) => Ok(yml)
case None => Ok("self: play -> " + name + " " + version)
}
So we will always have some content even if the module doesn't exist.
ex
https://www.playframework.com/modules/repo/starwars/1.5/dependencies.yml
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the GET /modules/repo/:name/:version/dependencies.yml route and controllers.Modules.dependencies, then inspect the modulesLookup.findDependencies match in modules.scala. Reproduce the request for a nonexistent module such as starwars/1.5 and verify that the endpoint no longer returns dependency content for modules that do not exist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 42/100