playframework / playframework/play1

IO / play precompile broken

Open
#1,450 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.6k
Forks
671
Avg merge
12d 15h
Merged PRs (30d)
1

Description

Play Version (1.5.x / etc)

framework/src/play/libs/IO.java
broken in d6dae446e6bf3f61cc9b21431fae1713b6d782fe

Issue

We've been using play 1 for about 10 years now, together with lombok.

Recently tried to update to master and hit an issue where our lombok module python before() method was not executed - turned out the commands.py wasn't copied.

By going back and forth with versions and individual files I could nail down the file and revision at fault.

I don't know the exact change yet, but in
576fcc0de4a0a071dc7a2e6197d97d9c88b7ce43

everything works.

Going to d6dae446e6bf3f61cc9b21431fae1713b6d782fe
our lombok module isn't running anymore when precompile is executed.

Switching just
framework/src/play/libs/IO.java
back to the previous commit
576fcc0de4a0a071dc7a2e6197d97d9c88b7ce43
everything works again.

Same with master - if I just switch that single file back, everything works again.

Reproducible Test Case

Add a module with a before(...) function in commands.py and add some print statement there. Now run play precompile and you should see the difference. Didn't test this exact case, as this is just fyi, as we're probably going to fork play going forward, as it seems there won't be much development happening anymore.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with framework/src/play/libs/IO.java and compare it between d6dae446e6bf3f61cc9b21431fae1713b6d782fe and 576fcc0de4a0a071dc7a2e6197d97d9c88b7ce43. Reproduce with a module containing a before(...) function in commands.py, then run play precompile. Done means the module hook executes again and the commands.py file is copied as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, python
Domain
build-system, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.