playframework / playframework/play1
Support SameSite cookie (Strict, Lax, None)
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.6k
- Forks
- 671
- Avg merge
- 12d 15h
- Merged PRs (30d)
- 1
Description
Are you looking for help?
From Google Chrome 80, they are planning to released from february, 2020, they will force SameSite=None for all Cookies if we want to use for third-party context. If no SameSite is set, then Chrome will understand as SameSite=Lax. It seems to be reversed the result as before (SameSite=None by default). Please see: https://www.chromium.org/updates/same-site
Therefore, we need to update our cookies with declarative setting SameSite from Playframework Controller.
Play Version (1.5.x / etc)
Playframework 1.5.x
Expected Behavior
- Support SameSite enum inside the Http.Cookie
- SameSite enum supports three values: Strict, Lax and None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Http.Cookie and the Playframework Controller code that creates or updates cookies. Check how cookie attributes are currently represented, then verify that declarative settings can express Strict, Lax, and None and that each value is emitted correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100