Use just File.pathSeparator instead of a tricky hack

Open

#1,121 opened on Mar 15, 2017 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Java
Stars: 1.6k
Forks: 671
Avg merge: 12d 15h
Merged PRs (30d): 1

Description

cf in play.java for (String m : System.getenv("MODULES").split(Os.isWindows() ? ";" : ":")) {

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Open framework/src/play/Play.java at line 729 and inspect how the MODULES environment variable is split. Replace the platform-specific separator hack with File.pathSeparator, then verify that module paths are parsed correctly on both Windows and non-Windows systems.

Written by the indexing model from the issue text.

Assessment

Tech stack: java
Domain: backend
Issue type: Refactor
Difficulty: 1/5
Estimated time: Under an hour
Activity status: Stale
Clarity: Clearly specified
Newbie friendliness: 50/100

A short digest of beginner-friendly GitHub issues.