playframework / playframework/play-ws
[feature] Add support for `SameSite` attribute in `WSCookie`
Open
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 224
- Forks
- 92
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 28
Description
The SameSite cookie attribute is widespread, see e.g. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite#browser_compatibility.
It would be great if play-ws helped me consume SameSite attributes, e.g. by having a sameSite field on WSCookie.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the WSCookie API and trace how response Set-Cookie headers are parsed and represented. Check the existing cookie-related tests, then add coverage showing that SameSite is consumed into the new field; done means callers can read the attribute from WSCookie.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100