playframework / playframework/play-ws
Should store headers and query params as a list instead of a map
Open
Nobody has claimed this yet.
status:backlog
type:defect
- Dominant language
- Scala
- Stars
- 224
- Forks
- 92
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 28
Description
Storing as a map causes re-ordering of query params which might be undesirable in some cases. It would be fine to use a Seq[(String, String)].
See playframework/playframework#6884, specifically https://github.com/playframework/playframework/pull/6884#issuecomment-272674376
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the issue and the referenced Play Framework issue and pull-request discussion, especially the linked comment. Inspect where headers and query parameters are represented and consumed; done means their ordering is preserved through the HTTP client without breaking existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- api, networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100