playframework / playframework/play-samples
Use Play's WebSocketClient in samples
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 554
- Forks
- 548
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 57
Description
There are 4 different variants of WebSocket.java in variosu samples on play-samples:
MD5 (play-java-chatroom-example/test/controllers/WebSocketClient.java) = dd467ea512ecd3b5e4075a456cec6ec4
MD5 (play-java-websocket-example/test/controllers/WebSocketClient.java) = 4eabd6c7627da67173ecd32713b8547c
MD5 (play-scala-chatroom-example/test/controllers/WebSocketClient.java) = dd3b5b4c72dcaaed02e32d287aca6708
MD5 (play-scala-websocket-example/test/controllers/WebSocketClient.java) = ce5101be52df25961bc51ace1a213c96
Despite being different, it's very likely they can be merged and even promoted to Play's testkit tools.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the four WebSocketClient.java variants in play-java-chatroom-example/test/controllers, play-java-websocket-example/test/controllers, play-scala-chatroom-example/test/controllers, and play-scala-websocket-example/test/controllers. Identify their shared behavior and differences, then inspect the available Play testkit tools. Done means the samples use a consolidated client without losing their existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, networking, testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100