playframework / playframework/play-grpc
Improve port detection on testkit
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 41
- Forks
- 27
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 12
Description
To provide a client, play-grpc testkit scan the available endpoints looking for one supporting HTTP/2. The lookup should support other criteria (see comments in JavaAkkaGrpcClientHelpers)
e.g. a more correct code here should filter by HTTP/2 and user's akka.grpc.client."".use-tls and crash wonderfully if none is found.
Further improvements: what endpoint to choose if many endpoints fulfill both criteria (protocol version and use-tls) if/when we support such a setup.
Originally posted by @ignasi35 in https://github.com/playframework/play-grpc/pull/33/review_comment/create
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the comments in JavaAkkaGrpcClientHelpers and trace the testkit code that scans available endpoints for HTTP/2. Determine how the user's akka.grpc.client."".use-tls setting should affect selection, then add coverage for matching and no-match behavior. Choosing among multiple matching endpoints is identified as a separate design question.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- backend-api-design, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100