playcanvas / playcanvas/engine
BoundingBox, BoundingSphere, OrientedBox extra methods.
Open
Nobody has claimed this yet.
enhancement
good first issue
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
It worth finalizing consistency withing those three classes, so here is list of things to do:
BoundingBox
- Deprecate
intersectsand add another methodintersectsBoundingBoxwhich will have same functionality - Add
intersectsOrientedBoxmethod - Add
centerandhalfExtentsproperty reference
BoundingSphere
- Add
intersectsBoundingBoxmethod (calls box.intersectsBoundingSphere internally) - Add
intersectsOrientedBoxmethod - Add
centerandradiusproperty reference
OrientedBox
- Add
intersectsBoundingBoxmethod (calls box.intersectsOrientedBox internally) - Add
intersectsOrientedBoxmethod - Add
halfExtentsproperty reference - Property
worldTransformhas wrong reference
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the BoundingBox, BoundingSphere, and OrientedBox classes and read their existing intersection methods and property references first. Implement the listed symmetric intersection methods and references, correct OrientedBox.worldTransform, and verify that all requested methods and properties behave consistently with the existing implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100