playcanvas / playcanvas/engine

BoundingBox, BoundingSphere, OrientedBox extra methods.

Open
#858 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

It worth finalizing consistency withing those three classes, so here is list of things to do:

BoundingBox

  1. Deprecate intersects and add another method intersectsBoundingBox which will have same functionality
  2. Add intersectsOrientedBox method
  3. Add center and halfExtents property reference

BoundingSphere

  1. Add intersectsBoundingBox method (calls box.intersectsBoundingSphere internally)
  2. Add intersectsOrientedBox method
  3. Add center and radius property reference

OrientedBox

  1. Add intersectsBoundingBox method (calls box.intersectsOrientedBox internally)
  2. Add intersectsOrientedBox method
  3. Add halfExtents property reference
  4. Property worldTransform has wrong reference

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the BoundingBox, BoundingSphere, and OrientedBox classes and read their existing intersection methods and property references first. Implement the listed symmetric intersection methods and references, correct OrientedBox.worldTransform, and verify that all requested methods and properties behave consistently with the existing implementations.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
computer-graphics
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.