playcanvas / playcanvas/engine

CubeMap change faces from RGBM to non-RGBM not switching or LDR.

Open
#801 0 comments 0 reactions 1 assignee View on GitHub

@slimbuck is already working on this.

Since May 13, 2020.

area: graphics
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

If cubeMap has HDR faces (RGBM), then changing faces does not checks if they are LDR so texture remains RGBM, and leads to wrong rendering.
Calling assets.load(asset) re-validates it.

It should ignore RGBM flag if faces are LDR.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.