playcanvas / playcanvas/engine
Sound Listener ignores the autoRender property
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
I was looking at why we keep losing frame time in our app when the application is paused from rendering (hidden from view). We pause it using app.autoRender = false. However it looks like Sound Listener is ignoring the property, because its update is triggered before that, when application.update(dt) is called:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/framework/app-base.js at the application.update(dt) call around lines 2066-2071, then trace where the Sound Listener update is triggered. Check how app.autoRender is expected to affect updates while rendering is paused. Done means the Sound Listener no longer consumes frame time when autoRender is false, while normal updates continue when rendering is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100