playcanvas / playcanvas/engine
Clamping position in camera-controls only works on _move
Open
@kpal81xd is already working on this.
Since Feb 6, 2025.
area: scripts
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
It seems that https://github.com/playcanvas/engine/blob/main/scripts/esm/camera-controls.mjs#L800 is the only callsite that clamps the camera position, but in practice the camera can be moved by orbiting, panning, and zooming. It would be nice unify all these methods (and likewise with angle clamping).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.