playcanvas / playcanvas/engine
ESM Attribute events
Open
@marklundin is already working on this.
Since Sep 5, 2024.
enhancement
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
ESM Scripts by design do not trigger attr:{propName} events. In order to help migration, it would be helpful to provide some alternative. Something like;
import { Script, watch } from 'playcanvas';
class MyClass extends Script {
prop = 10;
constructor() {
watch(this, 'prop');
this.on('change:prop', console.log);
}
}
This allows user to attach events and can be applied to any class member, whether an attribute or not.
Any thoughts/input appreciated. @mvaligursky @willeastcott @Maksims @slimbuck
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.