playcanvas / playcanvas/engine

Closest value/time on a curve

Open
#6,738 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

It is often needed to get a closest point on a curve to some world point. This is a bit cumbersome to do today, so this is a feature request. We need a method that takes a value and returns closest value or time.

There is a private Curve.closest(time) method, which doesn't seem to be used anywhere. Anyhow, it just returns a closest key, which is not that useful, as I know the keys already. It also takes time, which is not known at first. Maybe a candidate to deprecate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the private Curve.closest(time) method and checking how Curve keys and values are represented. Determine the intended public API for finding the closest value or time to a world point, then add coverage showing the expected result; the issue does not name a test file or implementation location.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.