playcanvas / playcanvas/engine
Invalid Anim curves counting
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
When Anim Evaluator removes a clip during rebinding, it tries to decrease the curves counter:
However, it is an AnimTarget that doesn't have such property:
I think it is expected to reduce it on the related element of this._outputs[] instead:
As a result, we get an AnimTarget with NaN curves and output target object does not decrease the counter:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the Anim Evaluator rebinding path where a clip is removed, and inspect how the related element of this._outputs[] tracks its curves counter versus the AnimTarget. Reproduce the removal case and verify that the AnimTarget does not become NaN and the output target counter decreases correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100