playcanvas / playcanvas/engine

Memory leak in mesh CollisionMeshSystemImpl

Open
#5,837 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: physics
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

When a component with a mesh collider is disabled, it destroys its Ammo shape. Specifically, it destroys a btCompoundShape, but neither btBvhTriangleMeshShape children, nor btTriangleMesh.

Some discussions on possible solutions: #5818

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CollisionMeshSystemImpl and inspect the path used when a mesh-collider component is disabled, then read discussion #5818 for the proposed cleanup approaches. Confirm that destroying a compound shape also releases its btBvhTriangleMeshShape children and btTriangleMesh, and verify that the leak no longer occurs when the component is disabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.