playcanvas / playcanvas/engine
Shader chunk API needs finalizing
@slimbuck is already working on this.
Since Jun 14, 2022.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
We're getting more and more interest in the shader chunk system.
We need to finalize the API as currently all variables end with VS (vertex shader) and PS (pixel shader). As the term pixel shader isn't a WebGL term at the least I would suggest we change that. Also it's not common for us to have that format and it is against our coding standards (capitalized abbreviation)
Can we have a discussion here on a new format and migrate the API to it (we should be able to support backwards compatibility).
Possible suggestions:
material.chunks.fs.diffuseConst
material.chunks.vs.transform
Thoughts?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.