playcanvas / playcanvas/engine
Reorder standard-material data member declarations
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
Standard-material now has so many data members, it has become difficult to keep track of them all across the related pieces of code (like standard-material-parameters and our backend).
Please reorder the member declarations in standard-material and standard-material-parameters alphabetically.
We also need better descriptive names for _defineTex2D and _textureParameter, since these two functions add data members related to a material "channel" or "component" or similar, not just texture.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the standard-material and standard-material-parameters implementations, then inspect the related backend code and the _defineTex2D and _textureParameter functions. Reorder the member declarations alphabetically and choose descriptive names for the two functions that reflect material channels or components, keeping related references consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100