playcanvas / playcanvas/engine
GLB-parser: Add callbacks to handle all nodes of the scheme
Open
@slimbuck is already working on this.
Since Nov 30, 2022.
area: gltf
enhancement
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
Right now, in the container handler we can define the next callbacks according to different stages of asset loading: global, node, light, camera, animation, material, image, texture, buffer, bufferView. But it does not cover all nodes of the glTF scheme that has extension or extra, and one can't handle extension/extra for these nodes.
List of uncovered nodes that I just have found, but I'm not sure that there are all of them:
- Mesh.primitives
- Documentation
- Place in the code
- Public extensions: KHR_lights_shadows, CESIUM_primitive_outline
- Mesh
- Sampler
- Accessor
- Documentation: 1, 2
- Place in the code
- Scene
- Skin
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.