playcanvas / playcanvas/engine

GLB-parser: Add callbacks to handle all nodes of the scheme

Open
#4,893 1 comment 0 reactions 1 assignee View on GitHub

@slimbuck is already working on this.

Since Nov 30, 2022.

area: gltf enhancement
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

Right now, in the container handler we can define the next callbacks according to different stages of asset loading: global, node, light, camera, animation, material, image, texture, buffer, bufferView. But it does not cover all nodes of the glTF scheme that has extension or extra, and one can't handle extension/extra for these nodes.

List of uncovered nodes that I just have found, but I'm not sure that there are all of them:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.