playcanvas / playcanvas/engine
GGX issues
Open
Nobody has claimed this yet.
area: graphics
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
GGX seems to react to normals very weakly. Not sure if this is a bug or it's supposed to look like this
With GGX:
Without GGX:
Also note in the GGX image that we get weird black halo effects. This is most definitely a bug.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the GGX and non-GGX examples from the issue and tracing the engine's GGX shading and normal handling. The fix is complete when GGX responds appropriately to normals and the black halo effects shown in the report are gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100