playcanvas / playcanvas/engine
Reimplement AppBase.preload function using the new AssetListLoader
Open
Nobody has claimed this yet.
area: assets
enhancement
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
The functionality is very similar, and @ellthompson confirmed this should be doable. It will avoid having to maintain two copies of very similar functionality.
https://github.com/playcanvas/engine/blob/main/src/asset/asset-list-loader.js
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/framework/app-base.js around AppBase.preload and compare it with src/asset/asset-list-loader.js. Trace the existing preload behavior and the AssetListLoader interface before making changes. Done means AppBase.preload uses AssetListLoader while preserving the existing preload functionality without two similar implementations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100