playcanvas / playcanvas/engine

Cubemap faces loading with public API

Open
#3,551 1 comment 0 reactions 2 assignees View on GitHub

@mvaligursky is already working on this.

Since Oct 7, 2021.

area: graphics docs
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

Currently when loading cubemap faces, we use code such as

const cubemapAsset = new pc.Asset('xmas_cubemap', 'cubemap', null, {
        textures: [
                assets.xmas_posx.id, assets.xmas_negx.id,
                assets.xmas_posy.id, assets.xmas_negy.id,
                assets.xmas_posz.id, assets.xmas_negz.id
        ]
});
cubemapAsset.loadFaces = true;

which uses nun-public loadFaces property.

We should consider making this property public, or provide different public API to load cubemap faces.

See it mentioned here: https://github.com/playcanvas/engine/pull/3548#discussion_r723319766

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.