playcanvas / playcanvas/engine
Ionic path causes issues with asset loading
Open
Nobody has claimed this yet.
area: assets
enhancement
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
This should also accept ionic path:
if (xhr.responseURL && (xhr.responseURL.startsWith('file:///') || xhr.responseURL.startsWith('ionic:///'))) {
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/net/http.js at the responseURL handling around line 492 and compare the existing file:/// check with the requested ionic:/// path. Done means asset loading accepts both URL schemes without changing other responseURL behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100