playcanvas / playcanvas/engine
Make it possible to disable skybox rendering
Open
@slimbuck is already working on this.
Since Apr 16, 2021.
area: graphics
enhancement
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
It is currently not possible to set the prefiltered lighting data on the scene without also having the skybox render on the background.
You can achieve this by disabling the layer:
this.camera.camera.layers = this.camera.camera.layers.filter((l) => {
return l !== pc.LAYERID_SKYBOX;
});
However this will still cause meshes and shaders to be created for the skybox unnecessarily.
Add an option to the scene to not automatically fallback to prefiltered cubemap for the skydome.
See https://github.com/playcanvas/engine/blob/master/src/scene/scene.js#L388
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.