playcanvas / playcanvas/engine

Make it possible to disable skybox rendering

Open
#3,096 0 comments 0 reactions 1 assignee View on GitHub

@slimbuck is already working on this.

Since Apr 16, 2021.

area: graphics enhancement
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

It is currently not possible to set the prefiltered lighting data on the scene without also having the skybox render on the background.

You can achieve this by disabling the layer:

this.camera.camera.layers = this.camera.camera.layers.filter((l) => {
    return l !== pc.LAYERID_SKYBOX;
});

However this will still cause meshes and shaders to be created for the skybox unnecessarily.

Add an option to the scene to not automatically fallback to prefiltered cubemap for the skydome.

See https://github.com/playcanvas/engine/blob/master/src/scene/scene.js#L388

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.