playcanvas / playcanvas/engine
onVisibilityChange() as on/off in regards to (at least) sound/audio
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
If a developer is on the look out of making a music/audio player, the:
onVisibilityChange() {
if (this.isHidden()) {
this._soundManager.suspend();
} else {
this._soundManager.resume();
}
}
- function within the engine seems rigid. The user should be able to listen to the music, regardless of tab-focus or other focus-limiters. YouTube and other players can run in 'background'. The feature request consists of a change that lets developer decide, if the onVisibilityChange() should be/become active after export ... the feature can/should be at editor-level.
Cf https://forum.playcanvas.com/t/solved-audio-mutes-when-out-of-tab-focus-different-with-youtube/19346/2 as well.
//br and hope you will consider for next repo - thanks, from Thomas
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the engine's onVisibilityChange() handler and its _soundManager suspend/resume calls, then trace how editor-level settings are passed through export. Define the setting that lets developers choose whether visibility changes affect audio, and verify both configured behaviors with the engine's existing audio or visibility tests, if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- game-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100