playcanvas / playcanvas/engine
Is http.js success code listing extensive enough?
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
Looking at https://github.com/playcanvas/engine/blob/master/src/net/http.js#L485
For example, returning a status code of 204 is a valid response (https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204) but http.js would deem it to be an error and attempt to retry if enabled.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/net/http.js at line 485 and inspect how successful HTTP status codes are identified. Confirm the expected handling of status 204 and how retry behavior depends on that classification. Done means a valid 204 response is not treated as an error or retried.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100