playcanvas / playcanvas/engine

Lighting change when using batching/instancing

Open
#2,832 6 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

area: graphics
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

It seems there is a change in lighting with a number of models we are using in our game when using batching. I wasn't able to isolate why these models produce this change. The same happens both when using CPU batching in editor and hardware instancing with a coded solution.

Without batching:

image

With batching:

image

Same project url: https://playcanvas.com/editor/scene/1084394

  1. Toggle on/off batching by setting and unsetting the batch group on the Platform and boardMain entities.

Tested on windows/android Chrome.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.