playcanvas / playcanvas/engine
Implement replacement and deprecate shader parameters APIs
Open
@mvaligursky is already working on this.
Since Jan 27, 2021.
area: graphics
enhancement
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
- Material and MeshInstance
- function setParameters takes a name and a value, and internally stores it wrapped in an object
- function getParameters should return the value but instead returns the wrapped object, and value needs to be accessed using .data
- we should consider simplification / replacement system for scopes / scopeIds as well
- instead of 'Parameters" the function names could use "Uniforms"
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.