playcanvas / playcanvas/engine
Investigate disabling of image colour profiles
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 16.8k
- Forks
- 2k
- Avg merge
- 4h 32m
- Merged PRs (30d)
- 222
Description
The option of applying JPG colour profiles at load time was disabled in https://github.com/playcanvas/engine/pull/986. Ignoring colour profiles can cause issues, see https://forum.playcanvas.com/t/how-do-i-apply-gamma-correct-to-cubemap-textures/14741.
We must investigate why this was disabled and possibly whether we can re-enable it (though this may cause issues for existing projects).
cc @guycalledfrank
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pull request 986 to understand why applying JPG colour profiles was disabled, then review the linked forum discussion for the reported cubemap gamma issue. Trace the image-loading path and assess whether re-enabling profiles would affect existing projects; done means the rationale and compatibility impact are established with a clear recommendation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100