playcanvas / playcanvas/engine

Updating material.cubemap doesn't update prefiltered textures

Open
#1,503 0 comments 0 reactions 1 assignee View on GitHub

@slimbuck is already working on this.

Since May 5, 2020.

area: graphics
Dominant language
JavaScript
Stars
16.8k
Forks
2k
Avg merge
4h 32m
Merged PRs (30d)
222

Description

If a material has an existing prefiltered cubemap set, then updating the material's cubemap property material.cubeMap = cubemapAsset.resource will have no effect as this call doesn't update the prefiltered textures in the material.

Changing a material's cubemap should at least clear old cubemap data, and ideally update it to the new maps.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.