playcanvas / playcanvas/editor

Making change to template gives inapplicable diff

Open
#787 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: templates area: version control bug
Dominant language
TypeScript
Stars
1.3k
Forks
215
Avg merge
1d 29m
Merged PRs (30d)
30

Description

Description

Making a change to a template gives an inapplicable diff. Below the diff. These settings are not changed by the user at all. In this case the only thing that was changed is the width and height of the element component of the child entity.

image

Steps to Reproduce
  1. Create an entity with child entity that has an element component
  2. Make a new template of this entity
  3. Duplicate this entity
  4. Make some changes in width/height of the element component
  5. Apply change to all
Project

https://playcanvas.com/project/942481/overview/templateissueone

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the linked PlayCanvas project using the listed template and child-entity steps. Compare the generated diff after changing only the element width and height; the issue is done when applying the change no longer reports unrelated settings as changed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.