playcanvas / playcanvas/editor
Always show the dismiss X for the version control diff panel
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 215
- Avg merge
- 1d 29m
- Merged PRs (30d)
- 30
Description
Forum thread: https://forum.playcanvas.com/t/version-control-issue/22623
On some monitor resolutions/zoom levels, the version control diff panel doesn't fit on the display.
eg
In general, we should always try to fit the UI to the bounds of the window.
As a quick fix, maybe we should allows ESC hotkey to dismiss the window?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the version control diff panel in the editor UI and review the linked forum thread for the reported monitor and zoom conditions. Verify the panel's dismiss controls at constrained window sizes; done means the dismiss X remains usable, or ESC reliably dismisses the panel, without the UI exceeding the window bounds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100