playcanvas / playcanvas/editor
Add a launcher start method and event to access the Window object
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 215
- Avg merge
- 1d 29m
- Merged PRs (30d)
- 30
Description
A new method and event should be added when the launcher starts so that the Window object can be accessed. At the moment, editor.call("launcher:start", launcher) is triggered here, but a clearer and more convenient API is needed to work with the opened window.
const features = popup ? 'popup' : undefined;
const launcher = window.open('', '_blank', features);
if (launcher) {
launcher.opener = null;
launcher.location = url;
editor.call("launcher:start", launcher); // Fire event
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the launcher startup path shown in the issue, where window.open creates the launcher and editor.call("launcher:start", launcher) is triggered. Trace how launcher methods and events are exposed, then add the requested start method and event so the opened Window object is accessible through the clearer API. Done means the API is available when the launcher starts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100