planetscale / planetscale/migration-scripts

Fix hardcoded security group ID and suggested improvement for SSL mode handling for RDS

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
32
Forks
9
Avg merge
3d 3h
Merged PRs (30d)
1

Description

Issue

While running the migration script, I encountered the following error:

An error occurred (InvalidParameterValueException) when calling the CreateReplicationInstance operation: The provided security group identifier or name is invalid. Please verify and provide a valid security group identifier or name.

After some investigation, I found that the script includes a hardcoded SECURITY_GROUP_ID, which is specific to the original author’s AWS environment. This ID will not exist in other users’ accounts and causes the script to fail unless updated manually.

Suggested fix

  • Remove the hardcoded SECURITY_GROUP_ID, or
  • Allow users to optionally pass in their own security group ID.
  • In my testing, omitting the security group entirely worked fine.

Thanks for your work on this project!

P.S. in the docs, you note that users migrating from Neon must use the --tls flag. This is likely true for all RDS users as well. Alternatively, they could set the parameter rds.force_ssl to 0.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the migration script's SECURITY_GROUP_ID definition and the documentation describing the --tls flag. Trace how replication-instance creation receives the security group, then review the RDS SSL guidance. Done means the script no longer depends on the author's account-specific ID, users can supply one if needed, and the documentation accurately explains TLS for RDS.

Written by the indexing model from the issue text.

Assessment

Tech stack
aws, postgresql, shell
Domain
cloud, databases, documentation
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.