planetscale / planetscale/ghcommit

Symlinks aren't handled correctly

Open
#83 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
60
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Unsure if this should be here, or in the ghcommit-action repo. It appears likely there's an assumption being made about the file modes when generating the commit blobs. This causing this utility (and dependent action) to generate defunct commits.

Reproducer: Create a new, or modify an existing, symlink to file in the repo. Run the utility (or Github action).

Expected result: the symlink is created/updated to point to the target file.

Actual result: the symlink points to a non-existent file. The name of this file is the contents of the symlink target.

As I'm able to use another action achieve a similar result successfully (qoomon/actions--create-commit), I presume this isn't a limitation of the GH API, but something specific to its usage here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a new or modified symlink, then inspect the utility's commit blob generation and file-mode handling. Compare the generated commit with the expected symlink target behavior and the successful qoomon/actions--create-commit result. Done means the utility and dependent action create or update symlinks that point to the target file rather than treating the target contents as a filename.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, go, graphql
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.