planetarium / planetarium/lib9c
Reactive subjects should be private
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 30
- Forks
- 56
- Avg merge
- 9h 2m
- Merged PRs (30d)
- 6
Description
In ActionRenderer and BlockRenderer has Subject<T> public property. It is used as Subject<T>.OnNext() outside of the class. But each class provides a public function that does the same thing, so use the method instead and should make the property private.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ActionRenderer and BlockRenderer definitions and inspect their Subject properties and the public methods that already perform the same action. Replace external Subject.OnNext() usage with those methods and make the properties private. Verify that the project builds and that existing tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100