pipe-cd / pipe-cd/pipecd

Legacy v0 tool installer hardcodes amd64 binaries, breaking darwin/arm64 hosts

Open
#7,005 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.4k
Forks
364
Avg merge
1d 4h
Merged PRs (30d)
84

Description

What happened:

The legacy piped v0 tool registry hardcodes amd64 in every Darwin (and Linux) install script for kubectl, kustomize, helm, and terraform. On an Apple Silicon (darwin/arm64) host, toolregistry.InitDefaultRegistry/installKubectl/installKustomize/installHelm/installTerraform in pkg/app/piped/toolregistry/tool_darwin.go unconditionally download the darwin/amd64 build of each tool, so the resulting binaries cannot execute natively on arm64 hosts.

This affects both local development and any test suite that exercises these code paths.

What you expected to happen:

The legacy v0 tool registry should resolve the host OS/architecture dynamically (the same way the newer pipedv1 tool registries already parameterize {{ .Os }} / {{ .Arch }} in their install scripts), so it downloads a binary compatible with the host architecture.

How to reproduce it:

  1. Use a darwin/arm64 machine (e.g. Apple Silicon Mac).
  2. From the repository root, run:
    go test ./pkg/app/piped/platformprovider/kubernetes/...
    
  3. Observe failures such as:
    fork/exec /tmp/piped-bin/helm: bad CPU type in executable
    
    in helm_test.go and kustomize_test.go, because the previously-downloaded darwin/amd64 helm/kustomize binaries cannot run on arm64.
  4. Inspect pkg/app/piped/toolregistry/tool_darwin.go (lines ~17-55) and confirm every download URL is pinned to darwin/amd64, regardless of runtime.GOARCH.

Environment:

  • piped version: repository checkout (master)
  • control-plane version: not applicable
  • Others: reproduced on macOS arm64 (Apple Silicon); confirmed via static inspection that pkg/app/piped/toolregistry/tool_darwin.go and pkg/app/piped/toolregistry/install.go never reference runtime.GOARCH, unlike the pipedv1 tool registries (e.g. pkg/app/pipedv1/plugin/kubernetes/toolregistry/scripts.go, pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go) which already template {{ .Os }}/{{ .Arch }} from runtime.GOOS/runtime.GOARCH.

Suspected root cause:

The older v0 tool registry (pkg/app/piped/toolregistry) uses static, OS-specific install scripts written before Apple Silicon support was considered, while the pipedv1 tool registries were already generalized to resolve the host architecture at install time.

Proposed direction:

Parameterize the Darwin (and Linux) install scripts in pkg/app/piped/toolregistry with the host architecture (runtime.GOARCH), following the pattern already used by the pipedv1 tool registries, and add regression coverage asserting the rendered install scripts reference the host architecture rather than a hardcoded value.

Acceptance criteria:

  • Helm, kubectl, kustomize, and Terraform install scripts reference the host architecture instead of a hardcoded amd64.
  • The legacy (pkg/app/piped/toolregistry) and pipedv1 tool registries no longer diverge on architecture handling.
  • Focused tests cover the rendered install scripts for a non-amd64 architecture.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with pkg/app/piped/toolregistry/tool_darwin.go and install.go, then compare the architecture templating in pkg/app/pipedv1/plugin/kubernetes/toolregistry/scripts.go and pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go. Run the focused Kubernetes tests, including helm_test.go and kustomize_test.go, and add coverage for rendered scripts on a non-amd64 architecture. Done means all four legacy install scripts use the host architecture and the tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, helm, kubernetes, terraform
Domain
devops, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.