Piped v1 Cloud Run plugin panics on deployment and livestate entry points
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 364
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 84
Description
What happened:
The piped v1 Cloud Run plugin exposes deployment and livestate entry points that still call panic("implement me"). Any request that reaches ExecuteStage, DetermineVersions, DetermineStrategy, or GetLivestate will crash the plugin process instead of returning a controlled error.
What you expected to happen:
Cloud Run plugin requests should either complete successfully or return an explicit error without panicking the process.
How to reproduce it:
- Open
pkg/app/pipedv1/plugin/cloudrun/deployment/plugin.goandpkg/app/pipedv1/plugin/cloudrun/livestate/plugin.go. - Inspect
Plugin.ExecuteStage,Plugin.DetermineVersions,Plugin.DetermineStrategy, andPlugin.GetLivestate. - Invoke any of those exported methods from a focused unit test or a small harness.
- Observe that the current implementation panics immediately because each method ends in
panic("implement me").
Environment:
pipedversion: repository checkout on 2026-07-07control-planeversion: repository checkout on 2026-07-07- Others: reproduced from current
mastercheckout by static inspection of the exported Cloud Run plugin handlers
Summary
The v1 Cloud Run plugin binary is registered with both deployment and livestate handlers, but several required methods are still stubbed with panics.
Affected Area
pkg/app/pipedv1/plugin/cloudrun
Steps to Reproduce
- Build or inspect the Cloud Run v1 plugin module.
- Call
ExecuteStage,DetermineVersions, orDetermineStrategyondeployment.Plugin. - Call
GetLivestateonlivestate.Plugin. - Observe process termination from
panic("implement me")instead of an error response.
Expected Behaviour
Cloud Run plugin handlers should never crash the plugin process. Unsupported behavior should be reported through explicit errors until full implementations exist.
Actual Behaviour
The exported handlers panic immediately, which can terminate the plugin process when those code paths are exercised.
Technical Evidence
pkg/app/pipedv1/plugin/cloudrun/deployment/plugin.go:51-63pkg/app/pipedv1/plugin/cloudrun/livestate/plugin.go:27-29pkg/app/pipedv1/plugin/cloudrun/main.goregisters both deployment and livestate plugins throughsdk.NewPlugin(...), so these panic paths are part of the published plugin surface.
Suspected Root Cause
The Cloud Run v1 plugin skeleton was merged before deployment and livestate handler implementations were completed.
Proposed Direction
Replace the panic stubs with explicit returned errors for unsupported operations, or gate registration of unfinished handlers until complete implementations are ready. Add regression tests covering each handler so future changes cannot reintroduce process panics.
Acceptance Criteria
- Cloud Run plugin deployment and livestate entry points no longer panic.
- Unsupported operations return explicit errors instead.
- Focused unit tests cover
ExecuteStage,DetermineVersions,DetermineStrategy, andGetLivestate.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/app/pipedv1/plugin/cloudrun/deployment/plugin.go and pkg/app/pipedv1/plugin/cloudrun/livestate/plugin.go, then inspect registration in pkg/app/pipedv1/plugin/cloudrun/main.go. Exercise ExecuteStage, DetermineVersions, DetermineStrategy, and GetLivestate from focused unit tests. Done means these entry points no longer panic, unsupported operations return explicit errors, and regression tests cover each handler.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cloud, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100