pipe-cd / pipe-cd/pipecd

plan-preview returns "no updated applications" when trigger.onCommit.disabled is true

Open
#6,722 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
1.4k
Forks
364
Avg merge
1d 4h
Merged PRs (30d)
84

Description

In our setup every app has trigger.onCommit.disabled: true.

The side effect is that pipectl plan-preview (and the actions-plan-preview GitHub Action) always returns "no updated applications" for us. We lose the PR diff preview entirely, even though that's
exactly what we'd want during code review.

The gate is here:

// pkg/app/piped/trigger/determiner.go
func (d *OnCommitDeterminer) ShouldTrigger(...) (bool, error) {
    if appCfg.Trigger.OnCommit.Disabled {
        return false, nil
    }
    ...
}

builder.findTriggerApps uses the same determiner, so apps with onCommit.disabled: true are filtered out before any diff is computed.

Would it be possible to add a flag like --skip-trigger-check to pipectl plan-preview (and a corresponding input on actions-plan-preview) that bypasses this gate? plan-preview is a read-only operation, so
opting in per-invocation feels safer than changing the app config. Default would stay as today.

Happy to send a PR if the direction sounds good.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in pkg/app/piped/trigger/determiner.go and trace how builder.findTriggerApps is used by pipectl plan-preview and the actions-plan-preview GitHub Action. Check the existing plan-preview flag and action-input entry points first; done means an opt-in bypass produces the PR diff preview for apps with trigger.onCommit.disabled, while the default behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, go
Domain
ci-cd, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.