All changes are listed as internal changes
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 364
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 84
Description
What happened:
All changes are listed as internal changes.
ref; https://github.com/pipe-cd/pipecd/pull/5023#issuecomment-2207704494
What you expected to happen:
The PR labels in the config file are listed as not internal changes.
https://github.com/pipe-cd/pipecd/blob/f71f39c2dc75340963fa3e98bd07451818a6053d/RELEASE#L8-L18
Currently, we have to include the configured message in the commit body.
But we sometimes want to label the PR after it's merged.
How to reproduce it:
Create release notes with the acitons-gh-release with changes that PR has non-internal changes label.
Environment:
pipedversion:control-planeversion:- Others:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with RELEASE lines 8-18 and the actions-gh-release reproduction described in the issue, using pull request labels as the input. Trace how release notes classify those labels, then verify that a non-internal PR label is listed as a non-internal change without requiring the configured message in the commit body.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, github-actions
- Domain
- release
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100