Rollback stage for K8s app is not removing the newly added resources in the new commit
Open
Nobody has claimed this yet.
kind/bug
- Dominant language
- Go
- Stars
- 1.4k
- Forks
- 364
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 84
Description
What happened:
https://github.com/pipe-cd/pipe/blob/master/pkg/app/piped/executor/kubernetes/rollback.go
Currently, it only removes "canary", "baseline" resources.
What you expected to happen:
How to reproduce it:
Environment:
pipedversion:control-planeversion:- Others:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pkg/app/piped/executor/kubernetes/rollback.go and trace how rollback currently handles canary and baseline resources. Identify how resources newly added by the new commit are represented and determine the expected removal behavior; verify that rollback removes those resources without affecting retained ones.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100