pingdotgg / pingdotgg/t3code

[Bug]: Commit action changes staging before message generation succeeds

Open
#9,070 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
23k
Forks
5.9k
Avg merge
11h 14m
Merged PRs (30d)
357

Description

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/server

Steps to reproduce
  1. Have staged and untracked changes.
  2. Make commit-message generation fail, such as by using a signed-out provider.
  3. Click Commit.
Expected behavior

No commit is created and the existing staging is unchanged.

Actual behavior

The commit flow runs git reset / git add -A before generating the message. If generation fails, the index stays changed.

Impact

Medium

Version or commit

main @ 2d156a83b

Environment

Any Git repository; provider failure is required to trigger the unsafe exit path.

Workaround

Restore the intended staging manually before the next commit.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in apps/server and trace the Commit action through the path that runs git reset and git add -A before message generation; reproduce with staged and untracked changes plus a signed-out provider. Done means a generation failure leaves the existing staging unchanged and creates no commit.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, typescript
Domain
backend, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.