pingdotgg / pingdotgg/t3code

[Bug]: Pull request All commits diff stays stale after new commits

Open
#7,310 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
23k
Forks
5.9k
Avg merge
11h 14m
Merged PRs (30d)
357

Description

Before submitting
  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.
Area

apps/web

Steps to reproduce
  1. Open a pull request in T3 Code.
  2. Open its Code tab with All commits selected.
  3. Push another commit to the pull request.
  4. Wait for the pull request detail header to refresh.
  5. Compare the header's updated state with the aggregate diff shown in All commits.
Expected behavior

When the pull request receives new commits, its detail data and All commits diff should refresh together and show one coherent snapshot.

Actual behavior

The detail header updates while the mounted aggregate diff remains on an older snapshot. Switching to an individual commit and back can expose the stale aggregate until it is explicitly refreshed.

Impact

Major degradation or frequent failure

Version or commit

main before #7167

Environment

Web and desktop clients using the shared pull request detail UI.

Logs or stack traces

Not applicable.

Screenshots, recordings, or supporting files

Not applicable.

Workaround

Explicitly refresh the pull request diff after new commits arrive.

Implemented in #7167.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in apps/web and trace the shared pull request detail UI used by the web and desktop clients. Compare the refresh path for the detail header with the mounted All commits aggregate diff, then verify that both display one coherent snapshot after new commits arrive. The issue notes that this was implemented in #7167.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.