pingcap / pingcap/tiup

Better support for separate data paths

Open
#854 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status/discuss type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:

When using separate path for raftdb, tiup doesn't create the path if missing, also doesn't delete the path when cluster is destroyed.

Reproduce:

server_configs:
  tikv:
    raftstore.raftdb-path: "/data4/tabokie/tmp/raft"

deploy with error (tikv can't find the path):

Error: init config failed: 172.16.5.32:20187: executor.ssh.execute_failed: Failed to execute command over SSH for 'pingcap@172.16.5.32:22' {ssh_stderr: invalid configuration: entity not found
, ssh_stdout: , ssh_command: export LANG=C; PATH=$PATH:/usr/bin:/usr/sbin /data4/tabokie/tmp/tikv-20187/bin/tikv-server --config-check --config=/data4/tabokie/tmp/tikv-20187/conf/tikv.toml --pd=""}, cause: Process exited with status 1: check config failed

Describe the feature you'd like:

When config contains separate paths, take them into consideration on cluster setup/destroy.

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing tiup's cluster setup and destroy entry points for the tikv server_configs shown in the issue, focusing on how separate raftdb paths are handled. Verify the behavior with a missing /data4/tabokie/tmp/raft path: setup should account for it and destroy should clean it up.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.