pingcap / pingcap/tiup

Merge DM into cluster

Open
#853 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type/feature-request
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Feature Request

Is your feature request related to a problem? Please describe:

Seems most of the business logic of components/dm and pkg/cluster overlaps. Should we consider separating the two parts of common logic to reduce code duplication, and reduce maintenance costs.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the business logic in components/dm/ with pkg/cluster/ and identifying the overlapping responsibilities described in the issue. Define which common logic should be separated and how both parts will use it; done means duplication and maintenance overlap are reduced without leaving the two areas inconsistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.