pingcap / pingcap/tiup

when the first command is not finished, then received the second command, the system may need add a lock for this

Open
#809 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    for example:
    the cluster is starting, use 'tiup dm restart' command to restart the cluster
    the cluster is starting, use 'tiup dm destroy' command to destroy the cluster
  2. What did you expect to see?

the second command should return an error

  1. What did you see instead?

  2. What version of TiUP are you using (tiup --version)?

[root@localhost ~]# tiup --version
v1.0.9 tiup
Go Version: go1.13
Git Branch: master
GitHash: 41fbacf
[root@localhost ~]# tiup dm --version
Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm --version
tiup version v1.1.2 tiup
Go Version: go1.13
Git Branch: release-1.1
GitHash: 7cb85b9-dirty
[root@localhost ~]#

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the scenario with tiup dm restart or tiup dm destroy while the cluster is starting, using the reported TiUP versions as a reference. Trace the command handling and define done as the second command returning an error instead of running concurrently.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.