pingcap / pingcap/tiup

There are some incorrect description in the response of the 'tiup dm --version' command

Open
#791 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status/TODO type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    [root@localhost ~]# tiup dm --version
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm --version
    tiup version v1.1.2 tiup
    Go Version: go1.13
    Git Branch: release-1.1
    GitHash: 7cb85b9-dirty
    [root@localhost ~]#
    [root@localhost ~]# tiup --version
    v1.0.9 tiup
    Go Version: go1.13
    Git Branch: master
    GitHash: 41fbacf

  2. What did you expect to see?
    there is a 'tiup version' in 'tiup dm --version' response too, but I think, it should be dm version here.
    because I got a different tiup version by 'tiup --version' command

  3. What did you see instead?

both 'tiup dm --version' and 'tiup --version' response a tiup version, but their values are different.

  1. What version of TiUP are you using (tiup --version)?
    [root@localhost ~]# tiup --version
    v1.0.9 tiup
    Go Version: go1.13
    Git Branch: master
    GitHash: 41fbacf
    [root@localhost ~]# tiup dm --version
    Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm --version
    tiup version v1.1.2 tiup
    Go Version: go1.13
    Git Branch: release-1.1
    GitHash: 7cb85b9-dirty
    [root@localhost ~]#

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the tiup dm --version and tiup --version command entry points, comparing how each assembles its version response. Done means tiup dm --version reports the DM version rather than an inconsistent TiUP version, with relevant command tests covering the output.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.