pingcap / pingcap/tiup

node param in 'tiup dm scale-in' is mandatory, please add it in command help info

Open
#790 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status/TODO type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    [root@localhost ~]# tiup dm scale-in --help
    Scale in a DM cluster

Usage:
tiup dm scale-in [flags]

  1. What did you expect to see?

tiup dm scale-in -N [flags]

  1. What did you see instead?

Usage:
tiup dm scale-in [flags]
all flags are descripted as optional

  1. What version of TiUP are you using (tiup --version)?

[root@localhost ~]# tiup --version
v1.0.9 tiup
Go Version: go1.13
Git Branch: master
GitHash: 41fbacf
[root@localhost ~]#
[root@localhost ~]# tiup dm --version
Starting component dm: /root/.tiup/components/dm/v1.1.2/tiup-dm --version
tiup version v1.1.2 tiup
Go Version: go1.13
Git Branch: release-1.1
GitHash: 7cb85b9-dirty
[root@localhost ~]#

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the tiup dm scale-in command entry point and inspect how its help usage is defined. The work is complete when tiup dm scale-in --help shows the required -N <node-name> parameter and accurately describes its usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.