pingcap / pingcap/tiup

Use local manifest by default

Open
#647 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status/TODO type/bug
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

At this time tiup cluster will fetch manifest in every action to make sure the manifest is newest. In fact, some actions (reload, scale-in) don't need the newest one.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tiup cluster manifest-fetch path and the entry points for reload and scale-in. Trace how each action decides whether to fetch a manifest, then verify that actions that do not need the newest manifest use the local copy by default while actions that require freshness still fetch it.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.