pingcap / pingcap/tiup

Double confirmation when editing configuration

Open
#319 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

category/usability status/discuss
Dominant language
Go
Stars
466
Forks
338
Avg merge
3d 7h
Merged PRs (30d)
8

Description

Generally editors will ask for a confirmation to save the changes. tiup-cluster asks it again just make the procedure complicated unnecessary. Just like git won't ask you again whether to apply the commit log message after editor exits.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tiup-cluster configuration-editing entry point and trace how confirmation is handled after the editor exits. Compare the flow with the issue's git analogy and verify that saving an editor-confirmed configuration does not trigger an unnecessary second confirmation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.